Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mention.js #741

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Mention.js #741

wants to merge 1 commit into from

Conversation

1shaked
Copy link

@1shaked 1shaked commented Apr 21, 2024

added the start and end position which is giving

Fixes #ABC

What did you change (functionally and technically)?

Checklist (remove this list before you submit the PR)

  • Are there tests for the new code?
  • Does the code comply to our code conventions?
  • Does the PR resolve the whole issue?

Additional review hints (remove this list before you submit the PR)

  • Besides the code review, what should the reviewer test?
  • Are there any edge cases?
  • Do you have any test files or test set-up?
  • Could your changes cause side effects elsewhere in the code base?

@1shaked
Update Mention.js
0f2462c 
added the start and end position which is giving
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2024

⚠️ No Changeset found

Latest commit: 0f2462c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-mentions ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2024 10:51am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@1shaked